@Friendica Developers Is there someone with admin privileges from git.friendi.ca? I've tried registering my account many times but I never received the activation email so I cannot activate my account. I already tried it with different emails, looked into spam and so on.
Could someone please activate my account "Art4" or check why I don't receive any emails? Thank you!
Roland Häder likes this.
reshared this
Hello !Friendica Developers,
I'm testing my Friendica test instance on my server. I noticed some flaws and bugs and reported them on Github. While looking at the code I think there is some minor and major refactoring needed. Where is a good place to meet some maintainers like @Hypolite Petovan to talk about the roadmap? Is this group the best place?
like this
Friendica Developers reshared this.
Some first thoughts are:
This will show us the places that need urgent refactoring. It will improve the parameter and return types and might fix many PHP notices/warnings/errors.
Friendica Developers reshared this.
art4 test-account likes this.
art4 test-account likes this.
@art4 @Michael Vogel This list looks similar to the one I made for myself half a dozen years ago, and feels extremely ambitious to me. My advice would be to pace yourself, you're dealing with an extensive codebase with a lot of legacy features.
For example, the local Composer binary cannot be upgraded to version 2 because of our reliance on fxp/composer-asset-plugin that enables us to manage frontend dependencies from Composer as well. No version of this plugin exists for Composer 2 and the author has been redirecting people towards one of his more recent projects that inverts the hierarchy by making Composer dependencies available from npm (if I understood correctly).
Similarly, over the past 5 years, I've done some static code analysis and fixed hundreds of warnings using PHP Scrutinizer but I had to stop because of the false positives (see github.com/friendica/friendica…). Similarly, PHPStan will not be happy with many of the remaining legacy files (mainly in the mod/ folder).
Database-less tests would be great, I wouldn't have any idea where to start. @Philipp Holzer did a great job creating the current test framework but any improvement is welcome.
Problem is that the support for Composer 1 will end next year. So we need to do something there. I'm completely lost here.
Concerning the mod files: I think that it should be possible to transform the remaining 7 files without too much problems. Except from photos.php most other are relatively small.
@Michael Vogel @Philipp Holzer @art4 And item.php?
I'm with you for the replacement of the Composer plugin. I don't want to go back to bundling the frontend libraries with the code, but I have little to no experience with npm or webpack as a replacement.
item.php several version ago to a level that now the functions are cleaned up. It shouldn't be a problem anymore.art4 test-account likes this.
Friendica Developers reshared this.
This list looks similar to the one I made for myself half a dozen years ago, and feels extremely ambitious to me. My advice would be to pace yourself, you're dealing with an extensive codebase with a lot of legacy features.
Don't worry, I'm doing this for many years now and I love it. The trick is to establish processes to reach an minimum code stability. New code must reach this minimum standard and old code can be improved step by step. PHPStan makes this easy with little gamification to reach the "levels" starting with 0.
or example, the local Composer binary cannot be upgraded to version 2 because of our reliance on fxp/composer-asset-plugin that enables us to manage frontend dependencies from Composer as well. No version of this plugin exists for Composer 2 and the author has been redirecting people towards one of his more recent projects that inverts the hierarchy by making Composer dependencies available from npm (if I understood correctly).
No problem, I already created a PR for this problem: github.com/friendica/friendica…
Similarly, over the past 5 years, I've done some static code analysis and fixed hundreds of warnings using PHP Scrutinizer but I had to stop because of the false positives (see github.com/friendica/friendica…). Similarly, PHPStan will not be happy with many of the remaining legacy files (mainly in the mod/ folder).
I already started the refactoring with PHPStan level 0, see github.com/friendica/friendica…
About the folder "mod" and "mods" I'm sure we will find a way to move them into the "src", "view" and other folders.
Database-less tests would be great, I wouldn't have any idea where to start. @Philipp Holzer did a great job creating the current test framework but any improvement is welcome.
The given tests are a great start for me improve and to familiarize myself with the code. I already have some improvements for the tests in mind.
Friendica Developers reshared this.
@art4 Thank you so much for the work you've already done!
Small precision: the "mods" folder is independent and doesn't have included PHP code in it. It includes suggested configuration files and a bookmarklet example.
art4 test-account likes this.
Michael 🇺🇦
in reply to art4 test-account • • •art4 test-account likes this.
Friendica Developers reshared this.